Fix build issue resulting from an old/incompatible folly or fbthrift previously installed on host

facebook / fboss

Facebook Open Switching System Software for controlling network switches.

Other

860 stars 295 forks source link

Fix build issue resulting from an old/incompatible folly or fbthrift previously installed on host #35

Closed rizard closed 6 years ago

rizard commented 8 years ago

Do not look in /usr/local/lib for fbthrift, folly, wangle, or any other 'external' package. The host might have a different version installed that is incompatible w/fboss...as I did. Cmake will prioritize /usr/local/lib and other typical install locations over the user-defined paths in the find_library() function. Specifying NO_DEFAULT_PATH will tell cmake to only use the PATH(s) explicitly specified in find_library().

oridb commented 8 years ago

Hm, the bot doesn't seem to have posted with the request yet -- Do you think you could sign the CLA?

https://code.facebook.com/cla

rizard commented 8 years ago

@oridb Just signed the CLA

oridb commented 8 years ago

Just as a heads up, this will probably take a little bit of time to land, since there's some cleanup I need to do before it can be imported to our internal repository, but I'm working on it. CMakeLists.txt has diverged a bit, so I need to make our tooling happy with resyncing.

capveg commented 7 years ago

Hi @rizard ! I'm cleaning this up now and I don't think this patch is needed any more. Can you confirm?

rizard commented 7 years ago

@capveg this looks like my netlink listener code. Maybe I pushed to the wrong branch at some point. The title of this commit seems to indicate it was related to the build

capveg commented 6 years ago

This is no longer needed - thanks for the contribution!