search

facebook / fboss

Facebook Open Switching System Software for controlling network switches.
Other
860 stars 295 forks source link

Allow zero interface multiple vlan configuration #69

Closed ventris closed 1 year ago

ventris commented 6 years ago

Summary: Currently when applying a configuration with multiple vlans and no L3 interfaces the message "Vlan 552 refers to 0 interfaces" is displayed and configuration is rejected. Most likely this was an accident in the original code as having no L3 interfaces is quite rare.

bluecmd commented 6 years ago

@covracer @capveg Do you think this can be merged somehow? Is it only the extra work on reverse syncing the commit back into FB that is stopping this, or do you see any issues with the commit itself?

capveg commented 5 years ago

Hi @bluecmd - finally digging into this.

We actually have an internal operational requirement that there's a 1:1 relationship between vlan and interfaces (and it's a config mistake if it's not) but I admit this is a totally reason thing in general.

What do you think about wrapping your change in an "#ifdef IS_OSS" to make this change for our open source FBOSS only?

bluecmd commented 5 years ago

Sounds good to us. I'll chat with @ventris and sync on this.