search

facebook / fboss

Facebook Open Switching System Software for controlling network switches.
Other
866 stars 301 forks source link

fboss build failure #86

Closed habeebmohammed closed 4 years ago

habeebmohammed commented 4 years ago

Hi

I am trying to build the FBOSS on the centos 7 server per README. Also installed dependencies.

export CPLUS_INCLUDE_PATH=/opt/rh/rh-python36/root/usr/include/python3.6m/ export PATH=/opt/rh/devtoolset-8/root/usr/bin/:/opt/rh/rh-python36/root/usr/bin:$PATH sudo ./build/fbcode_builder/getdeps.py build fboss

/opt/rh/devtoolset-8/root/usr/include/c++/8/bits/basic_string.h:3489:7: note: candidate expects 0 arguments, 3 provided /opt/rh/devtoolset-8/root/usr/include/c++/8/bits/basic_string.h: In instantiation of ‘struct std::basic_string<char, std::char_traits, folly::reentrant_allocator >::_Rep’: /opt/rh/devtoolset-8/root/usr/include/c++/8/bits/basic_string.h:3640:19: required from ‘std::basic_string<_CharT, _Traits, _Alloc>::~basic_string() [with _CharT = char; _Traits = std::char_traits; _Alloc = folly::reentrant_allocator]’ /tmp/fbcode_builder_getdeps-ZhomeZhabeebZfboss.gitZbuildZfbcode_builder-root/repos/github.com-facebook-folly.git/folly/experimental/symbolizer/ElfCache.h:68:52: required from here /opt/rh/devtoolset-8/root/usr/include/c++/8/bits/basic_string.h:3150:56: error: no class template named ‘rebind’ in ‘class folly::reentrant_allocator’ typedef typename _Alloc::template rebind::other _Raw_bytes_alloc; ^~~~ [5/201] Building CXX object CMakeFiles/folly_base.dir/folly/experimental/EnvUtil.cpp.o [6/201] Building CXX object CMakeFiles/folly_base.dir/folly/executors/TimedDrivableExecutor.cpp.o [7/201] Building CXX object CMakeFiles/folly_base.dir/folly/experimental/FunctionScheduler.cpp.o [8/201] Building CXX object CMakeFiles/folly_base.dir/folly/experimental/DynamicParser.cpp.o [9/201] Building CXX object CMakeFiles/folly_base.dir/folly/executors/SerialExecutor.cpp.o [10/201] Building CXX object CMakeFiles/folly_base.dir/folly/executors/ThreadPoolExecutor.cpp.o [11/201] Building CXX object CMakeFiles/folly_base.dir/folly/executors/TimekeeperScheduledExecutor.cpp.o ninja: build stopped: subcommand failed. Command '['/tmp/fbcode_builder_getdeps-ZhomeZhabeebZfboss.gitZbuildZfbcode_builder-root/installed/cmake-70sXSBX5BKHpcwdpi8LLyvIQG39LH3hh33Gr00Z-yWU/bin/cmake', '--build', '/tmp/fbcode_builder_getdeps-ZhomeZhabeebZfboss.gitZbuildZfbcode_builder-root/build/folly', '--target', 'install', '--config', 'Release', '-j', '8']' returned non-zero exit status 1. !! Failed

bkoray commented 4 years ago

That looks like a Folly issue. Trying to replicate now.

bkoray commented 4 years ago

@habeebmohammed It seems to build fine for me. Have how old was this? Getdeps pulls the latest version if it detects any changes, so perhaps there was a fix in between.

habeebmohammed commented 4 years ago

I have just tried with the latest code and got the same error. Attached full log. Please review and suggest if I miss anything.

build_log.txt Thanks

bkoray commented 4 years ago

Hi @habeebmohammed, could you check whether if https://github.com/facebook/folly/commit/b14c9ea61cb43665eb6ef6aa600f745483f1fe97 fixed the issue? In order to check, all you'll need to do is export variables and run getdeps, same as before. Getdeps will fetch the new changes, so you don't need to take any additional steps to incorporate this commit.

bkoray commented 4 years ago

I am closing this as fix is out and there were no feedback. Please feel free to reopen the issue if the error persists.