search

facebook / fbt

A JavaScript Internationalization Framework
https://facebook.github.io/fbt
MIT License
3.88k stars 178 forks source link

Update fbt peerDependencies to allow React 18. #374

Closed TJ09 closed 2 years ago

TJ09 commented 2 years ago

Summary

Resolves #372 by bumping the peer dependency to include React 18. This allows FBT to be properly used in projects that use React 18.

Changelog has also not been updated yet since there is no post-1.0.0 section.

Test plan

As mentioned in #372, FBT works just fine in my own projects when running React 18. CONTRIBUTING.md doesn't have any information on how to run tests, so I didn't (but the devDependencies for different packages seem to require anywhere from React 16 to 17, which is unchanged).

facebook-github-bot commented 2 years ago

@lacbs has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

lacbs commented 2 years ago

Note: I've simply used "react": ">=0.12.0" instead.