facebook / fbt

A JavaScript Internationalization Framework
https://facebook.github.io/fbt
MIT License
3.9k stars 178 forks source link

expand on the options object to show the demonstrated translation? #8

Open Pomax opened 5 years ago

Pomax commented 5 years ago

Currently the landing page at https://facebookincubator.github.io/fbt/ shows the english text text with a descriptor eg, an object with translation information keyed on that eg, and then a resultant translated snippet. However, the translation in the translated snippet is nowhere to be found in the translation object, so even if it's just to show an except of how things work, it's a good idea to show that there is a relation between all three aspects: currently the translated snippet does not appear to be based on anything related to the other two bits of code shown.

jrwats commented 5 years ago

Thanks for the feedback. I'll add that in!

Pomax commented 5 years ago

Thanks, and congrats on the release!