Fix missing `#include <fstream>`

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.

Apache License 2.0

2.55k stars 608 forks source link

Fix missing `#include <fstream>` #513

Closed carlocab closed 1 year ago

carlocab commented 1 year ago

Without this, the build fails with

error: implicit instantiation of undefined template 'std::basic_ifstream<char>'

Seen while building for Homebrew on macOS 12 at Homebrew/homebrew-core#108112.

The exact error is at https://github.com/Homebrew/homebrew-core/runs/7851989570?check_suite_focus=true#step:6:358.

Closes #512

facebook-github-bot commented 1 year ago

@vitaut has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

vitaut commented 1 year ago

Thanks!

carlocab commented 1 year ago

No problem. I'm a little curious why this didn't fail on your own OSS build tests. Is it due to a change in the header structure in newer versions of macOS?

vitaut commented 1 year ago

AFAICS rust generator is not a part of the OSS build: https://github.com/facebook/fbthrift/blob/main/thrift/lib/CMakeLists.txt.

carlocab commented 1 year ago

Huh, weird. We don't do anything special to enable it, so not sure why we hit this error.