facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.57k stars 608 forks source link

Add missing `#include` for macOS Catalina #517

Closed carlocab closed 2 years ago

carlocab commented 2 years ago

Without this, the build fails on macOS Catalina with the error

error: use of undeclared identifier 'errno'
    errno = 0;
    ^

Notably, this does not happen on macOS Big Sur, Monterey, or on Linux. Seen while building the latest tag of fbthrift for Homebrew at Homebrew/homebrew-core#108626.

Build logs available at https://github.com/Homebrew/homebrew-core/runs/7955648533?check_suite_focus=true#step:6:281.

facebook-github-bot commented 2 years ago

@vitaut has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

vitaut commented 2 years ago

Thank you!