search

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.55k stars 608 forks source link

set IMPORTED_LINK_INTERFACE_LIBRARIES to ${LIBGFLAGS_LIBRARY} for glog::glog (#31) #521

Closed Atry closed 1 year ago

Atry commented 1 year ago

Summary: X-link: https://github.com/facebook/fb303/pull/31

Previously Folly provided a polyfill of the GflagsFlagSaver symbol, which was removed since https://github.com/facebook/folly/commit/4dadde1256f74e756510a499c86459967f78afb9. Therefore, the glog should solve the GflagsFlagSaver symbol from gflags.

This diff added gflags libraries as a dependency of the CMake project glog::glog into fbcode_builder's FindGlog.cmake, so that the fbcode_builder users will be able to automatically link with gflags.

Differential Revision: D39220438

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D39220438