search

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.55k stars 608 forks source link

Add vcpkg installation instructions #523

Closed Adela0814 closed 1 year ago

Adela0814 commented 1 year ago

fbthriftis available as a port in vcpkg, a C++ library manager that simplifies installation for fbthriftand other project dependencies. Documenting the install process here will help users get started by providing a single set of commands to build fbthrift, ready to be included in their projects.

We also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64, UWP, ARM) to keep a wide coverage for users.

I'm a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library.

facebook-github-bot commented 1 year ago

Hi @Adela0814!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

vitaut commented 1 year ago

Thanks for the PR but it looks like instructions for installing any package in vcpkg are pretty much the same so I don't think it adds much value to copy them here.