search

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.55k stars 608 forks source link

Add -fsized-deallocation compile option (#9218) #528

Closed Atry closed 1 year ago

Atry commented 1 year ago

Summary: Fb-thrift uses C++17's operator delete, which requires -fsized-deallocation when building c++ source code with clang and libstdc++.

https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230

X-link: https://github.com/facebook/hhvm/pull/9218

Differential Revision: D39707592

Pulled By: Atry

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D39707592

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D39707592

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D39707592