search

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.55k stars 608 forks source link

GitHub Workflows security hardening #529

Closed sashashura closed 1 year ago

sashashura commented 1 year ago

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

facebook-github-bot commented 1 year ago

@nanshu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.