Closed ropoctl closed 1 year ago
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@vitaut is there a servicelab that needs to be triggered for this?
@ropoctl, sorry for a slow reply. Please let me know if you are still interested in having this reviewed and I'll find a POC from our Rust experts. You'll also need to rebase the PR.
@vitaut has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@ropoctl, do you plan to address feedback?
Hi @ropoctl!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with
CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!