search

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.55k stars 608 forks source link

No sudo on Mac #545

Closed elharo closed 1 year ago

elharo commented 1 year ago

The README suggests building with 

$ sudo ./build/fbcode_builder/getdeps.py install-system-deps --recursive fbthrift

However this fails on Mac OS X from the last several versions:

Error: Running Homebrew as root is extremely dangerous and no longer supported.
As Homebrew does not drop privileges on installation you would be giving all
build scripts full access to your system.
Command '['brew', 'install', 'autoconf', 'automake', 'boost', 'cmake', 'double-conversion', 'icu4c', 'libevent', 'libsodium', 'libtool', 'lz4', 'ninja', 'openssl@1.1', 'xz', 'zlib', 'zstd']' returned non-zero exit status 1.
!! Failed

I'm checking to see whether this works if it's simply run without sudo.

vitaut commented 1 year ago

You no longer need to pass sudo when installing dependencies and we'll update the readme shortly. Thanks for reporting!