search

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.57k stars 608 forks source link

build error fmt format #549

Closed restlesswind closed 1 year ago

restlesswind commented 1 year ago

https://github.com/facebook/fbthrift/blob/main/thrift/lib/cpp2/server/ParallelConcurrencyController.cpp#L159

It seems like the line should look "{{ParallelConcurrencyController executionLimit={}}}", executionLimit.load()); instead of "{{ParallelConcurrencyController executionLimit={}}}", executionLimit);

Mizuchi commented 1 year ago

Thanks for reporting. fmtlib broke it (https://github.com/fmtlib/fmt/commit/fce74caa15b24cbc0fcafe4706692cb06cb0b815). Let me check with the author.

vitaut commented 1 year ago

Fixed in https://github.com/facebook/fbthrift/commit/ae499882a1bfe8a6e2348e749a68010833ea1771.