facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.55k stars 608 forks source link

cmake: add `TokenBucketConcurrencyController.cpp` to libthriftcpp2 #553

Closed ZhongRuoyu closed 1 year ago

ZhongRuoyu commented 1 year ago

TokenBucketConcurrencyController.cpp was added in 7106bf3. This patch adds it to the list of libthriftcpp2's sources, so that it can be built.

Without this, fbthrift's dependents failed with the following error:

dyld: Symbol not found: __ZTVN6apache6thrift23TMConcurrencyControllerE
  Referenced from: /opt/homebrew/opt/fbthrift/lib/libthriftcpp2.1.0.0.dylib
  Expected in: flat namespace
 in /opt/homebrew/opt/fbthrift/lib/libthriftcpp2.1.0.0.dylib

The error was seen while packaging fbthrift 2023.05.15.00 for Homebrew at Homebrew/homebrew-core#130992.

prasad223 commented 1 year ago

fixed in f670c7c