search

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.55k stars 607 forks source link

Attempt to fix duplicate flag issue #579

Closed terrelln closed 8 months ago

terrelln commented 8 months ago

Summary: CacheLib noticed OSS build failures due to JSONProtocolCommon.cpp being linked into the build twice, after we added a GFLAG to that file.

This diff attempts to fix the issue by depending on thriftprotocol rather than duplicating the files.

The code claims that it couldn't depend on thriftprotocol due to a circular dependency (added in D24720566), but Sandcastle and GitHub Actions is passing, so it doesn't seem to still be an issue.

Differential Revision: D50505357

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50505357

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50505357

facebook-github-bot commented 8 months ago

This pull request has been merged in facebook/fbthrift@7d809773579a7ca86ebc20a6d2bd26946567ce5e.

facebook-github-bot commented 8 months ago

This pull request has been reverted by b09df90acedb92cbad5650fb232c1a75edfddc22.