search

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.55k stars 607 forks source link

Fix duplicate flags #580

Closed terrelln closed 8 months ago

terrelln commented 8 months ago

Summary: D50505357 attempted to fix the issue, but introduced dependency cycles that weren't caught by CI.

This diff fixes the issue by moving all the GFlag definitions to ProtocolGFlags.cpp and exposing this as a separate library thriftprotocolflags in CMake. Each library which includes a copy of the protocol sources depends on this library.

Differential Revision: D50521352

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50521352

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50521352

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50521352

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50521352