search

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.55k stars 607 forks source link

use system deps in github CI for fbthrift #595

Closed ahornby closed 2 months ago

ahornby commented 3 months ago

use system deps in github CI for fbthrift

Save some time by not rebuilding cmake & boost et al on each CI run

Summary:

Regenerated github actions with:

./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --src-dir=. --output-dir=.github/workflows fbthrift

Test Plan:

CI

ahornby commented 3 months ago

cc @vitaut looks like it speeds up GitHub CI

vitaut commented 2 months ago

So this bring the build time from ~38 to ~24 minutes? This is a nice improvement but I wonder if we can miss some build issues if we install dependencies instead of building with our own configs?

ahornby commented 2 months ago

So this bring the build time from ~38 to ~24 minutes? This is a nice improvement but I wonder if we can miss some build issues if we install dependencies instead of building with our own configs?

@vitaut its already done for folly, I think its low risk to do fbthrift CI as well. The instructions from README usage suggest using the system deps, so CI will now test that more accurately

vitaut commented 2 months ago

I'm fine with this change but you need to import it into fbsource.

facebook-github-bot commented 2 months ago

@ahornby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@ahornby merged this pull request in facebook/fbthrift@bcac89f33a4ae92e259516369fd8b81eba525a63.