search

facebook / fbthrift

Facebook's branch of Apache Thrift, including a new C++ server.
Apache License 2.0
2.55k stars 607 forks source link

CMakeLists: fix set_target_properties incorrect number of arguments #608

Closed barracuda156 closed 3 weeks ago

barracuda156 commented 4 weeks ago

Fix a configure failure due to a wrong number of arguments to set_target_properties

barracuda156 commented 4 weeks ago 
CMake Error at thrift/compiler/generate/CMakeLists.txt:46 (set_target_properties):
  set_target_properties called with incorrect number of arguments.

-- Configuring incomplete, errors occurred!
vitaut commented 3 weeks ago

Thanks for the PR. I recommend also reporting to CMake because they have this exact broken pattern in https://cmake.org/cmake/help/latest/guide/tutorial/Selecting%20Static%20or%20Shared%20Libraries.html

facebook-github-bot commented 3 weeks ago

@vitaut has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 weeks ago

@vitaut merged this pull request in facebook/fbthrift@8416d933832e2411698b0673fe515a6ca788b080.

barracuda156 commented 3 weeks ago

Thank you!