search

facebook / fishhook

A library that enables dynamically rebinding symbols in Mach-O binaries running on iOS.
BSD 3-Clause "New" or "Revised" License
5.18k stars 966 forks source link

Signedness tweaks #1

Closed kastiglione closed 10 years ago

kastiglione commented 11 years ago

Fishhook is awesome, thanks for sharing with everyone!

ReactiveCocoa uses DYLD interposing on OS X to capture asynchronous backtraces, and now with fishhook the same can be done on iOS.

When I integrated fishhook into ReactiveCocoa, a few signed conversion and comparison warnings were reported, but since RAC uses -Werror, they become errors.

If you're interested, here are the changes I made to remedy the signed conversion and signed comparison warnings.

kastiglione commented 11 years ago

A note about 3b37d711484cd08fa1b006cd9a79befcd27f4811, the commit message is misleading, it's not casting, just retyping. I can fix the commit message if desired.

0xced commented 10 years ago

This is apparently addressed by 823e2eb.

kastiglione commented 10 years ago

Thanks @0xced, closed.