search

facebook / fishhook

A library that enables dynamically rebinding symbols in Mach-O binaries running on iOS.
BSD 3-Clause "New" or "Revised" License
5.17k stars 965 forks source link

Fix iOS 14.5 crash #83

Open shino-996 opened 3 years ago

shino-996 commented 3 years ago

The mprotect function requires the address to be page size aligned. In iOS 14.5 Beta, some addresses of sections of __DATA_CONST and __AUTH_CONST segments are not aligned to the page size, the write protection will be added failed, and then the process may crash when writing to these addresses. So we can use vm_protect which not require the address to be page size aligned, instead of mprotect.

Besides, the protection of different pages in a section may be not the same. So we need to pass the address to be written into get_protection, not the first address of the section.

Fixed #80 and #82.

facebook-github-bot commented 3 years ago

Hi @shino-996!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

maniackk commented 3 years ago

I found some case that vm_protect return KERN_SUCCESS , but memory don't set VM_PROT_WRITE success. like mprotect method

shino-996 commented 3 years ago

I found some case that vm_protect return KERN_SUCCESS , but memory don't set VM_PROT_WRITE success. like mprotect method

It seems a problem which hooking the same function in multithread. The memory was set write protection in a thread but hasn't written, while the same memory has set readonly protection back in other thread.

tirodkar commented 2 years ago

@grp are there plans to merge these PR's? Unfortunately, these are necessary for iOS 14.5+ usage of fishhook and are breaking our users.

https://github.com/google/EarlGrey/issues/1641