facebook / flipper

A desktop debugging platform for mobile developers.
https://fbflipper.com/
MIT License
13.36k stars 952 forks source link

React Native Android example doesn't run - metro-hermes-compiler TypeError #2618

Open leotm opened 3 years ago

leotm commented 3 years ago

🐛 Bug Report

React Native Android example doesn't run, giving Cannot destructure property 'url' of 'connection.upgradeReq' as it is undefined from metro-hermes-compiler

Screenshot 2021-07-25 at 14 22 06

Screenshot 2021-07-25 at 14 23 37

To Reproduce

https://github.com/facebook/flipper#react-native-sdk--sample-app

Environment

M1 macOS 11.5 BigSur

leotm commented 3 years ago

Patching debuggerproxyserver.js to

Screenshot 2021-07-25 at 14 34 41

Led to connection.close is not a function also from metro-hermes-compiler

Then patching

Screenshot 2021-07-25 at 14 48 35

Got me up and running

Screenshot 2021-07-25 at 14 53 16

But with Flipper Device (google/android-emulator-m1-preview) error/warning Logs

https://pastebin.com/4Y3JvkHH (search: reactnativeflipperexample)

stale[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.