facebook / flipper

A desktop debugging platform for mobile developers.
https://fbflipper.com/
MIT License
13.34k stars 954 forks source link

Network plugin: don't parse req/res binaries (APP FREEZES) #4404

Open burzacoding opened 1 year ago

burzacoding commented 1 year ago

🐛 Bug Report

Hi, I'm currently using Flipper Desktop 0.176.1 on a Macbook Air M1 8gb 256gb and I noticed since a long time that when trying to debug API calls that contain files, the app freezes for a long time, sometimes more than 5 minutes, because it seems to be parsing the binaries into a text, so if we look at the Req/Res body (depends on which side is transferring the file) we usually get thousands+ of lines of parsed files into text.

To Reproduce

Simply upload any file with multipart/form-data ContentType and you will see what I'm talking about. In the chrome developers tools we directly see [Binary] instead of the parsed file, I think this could be the correct approach.

Environment

RN 0.66.4 Flipper Desktop: 0.176.1 (this problem is also present on previous versions) Android version: 12 iOS version: 16

anatooly commented 1 year ago

Yeap, Use Flipper from ~0.160 to current version 0.203 and always app freeze on upload file requests. Unpossible debug upload requests on REST API, GraphQL. RN all version from ~0.60 to 0.72

macbook i9 32 gb

minhchienwikipedia commented 1 year ago

Same issue when trying to upload image with form-data , please fix it

ridvanaltun commented 1 year ago

Related:

https://github.com/facebook/flipper/issues/215 https://github.com/facebook/flipper/issues/457 https://github.com/facebook/flipper/issues/4043 https://github.com/facebook/flipper/issues/3908

It is the most frustrating issue, any progress?

cpintos-sc commented 1 year ago

Hi @passy do you have time to check? This doesn't seem to be getting attention