facebook / flipper

A desktop debugging platform for mobile developers.
https://fbflipper.com/
MIT License
13.28k stars 953 forks source link

Question: Why does the official React Native template ship with an outdated Flipper SDK? #4440

Open henrymoulton opened 1 year ago

henrymoulton commented 1 year ago

Thank you Flipper maintainers for your work.

I noticed that there is no bump in the Flipper version with the React Native template in 0.71. https://react-native-community.github.io/upgrade-helper/?from=0.70.6&to=0.71.0

The file in the template points to FLIPPER_VERSION=0.125.0 See here: https://raw.githubusercontent.com/react-native-community/rn-diff-purge/release/0.71.0/RnDiffApp/android/gradle.properties

I also noticed from the docs:

By default, React Native might ship with an outdated Flipper SDK. To make sure you are using the latest version, determine the latest released version of Flipper by running npm info flipper. https://fbflipper.com/docs/getting-started/react-native/#using-the-latest-flipper-sdk

I wondered if there's anything we can do to increase certainty around what versions of Flipper will work with React Native.

Separately, since Flipper points to 0.125.0 shouldn't we be encouraging users to download Flipper Desktop 0.125.0 instead of pointing the download button e.g. "https://www.facebook.com/fbflipper/public/mac" to the latest Flipper Desktop version.

henrymoulton commented 1 year ago

Posting @kelset's reply here: https://twitter.com/Kelset/status/1615691253517107202?s=20

TheWirv commented 1 year ago

I mean, also, since the most recent versions haven't been working with release builds on iOS, it's probably good that the template doesn't ship with the latest release. See #4278 and #4457