search

facebook / flipper

A desktop debugging platform for mobile developers.
https://fbflipper.com/
MIT License
13.35k stars 955 forks source link

Flipper Doctor incorrectly reports "Android Studio is not installed." when using Jetbrains Toolbox on OSX #5436

Open kenyee opened 9 months ago

kenyee commented 9 months ago

🐛 Bug Report

The Flipper Setup Doctor incorrectly reports "Android Studio is not installed." when it's installed via Jetbrains Toolbox on OSX. Ditto w/ IDB when installed via Homebrew because it looks in /usr/local/bin for it instead of /opt/homebrew/bin

To Reproduce

Remove all installations of Android Studio from your Applications in OSX. Install Jetbrains Toolbox. Use JB Toolbox to install AndroidStudio.

Environment

Flipper version 0.239.0 AS Installed via JB toolbox only (I have latest stable, beta, canary all installed)

ihgvan commented 9 months ago

Same "Android Studio is not installed" symptom for me, but I haven't noticed any adverse effects yet.

kenyee commented 9 months ago

Oops...should have mentioned there are no adverse affects. But one of our devs was wondering why the doctor said it was broken so it's confusing 😸

VictorIreri commented 9 months ago

Looks like it's the code below that defines the Android Studio location so I guess that could be updated to include the default location for Android Studio when installing via JetBrains Toolbox, which seems to be the ~/Applications folder in the user directory. https://github.com/facebook/flipper/blob/efe2b4f58928fd8ce11132cd039b4a639c9399fc/desktop/doctor/src/index.tsx#L72-L73

Furthermore, the check should consider that the filename might not be exactly "Android Studio.app" especially if you have a Beta/Preview app installed e.g. Android Studio Iguana 2023.2.1 Beta 2.app or Android Studio Preview.app.

Also, it would be nice if that location could be configured by the user.

LaGregance commented 8 months ago

Looks like it's the following line that defines the Android Studio location so I guess that could be updated to include the default location for Android Studio when installing via JetBrains Toolbox, which seems to be the Applications folder in the user directory.

https://github.com/facebook/flipper/blob/efe2b4f58928fd8ce11132cd039b4a639c9399fc/desktop/doctor/src/index.tsx#L72-L73

Furthermore, the check should consider that the filename might not be exactly "Android Studio.app" especially if you have a Beta/Preview app installed e.g. Android Studio Iguana 2023.2.1 Beta 2.app or Android Studio Preview.app.

Also, it would be nice if that location could be configured by the user.

Same problem, I recently fresh install my Mac and install Android Studio using JetBrains Toolbox, so it's installed in ~/Applications (not /Applications)