search

facebook / flipper

A desktop debugging platform for mobile developers.
https://fbflipper.com/
MIT License
13.26k stars 951 forks source link

Forward declare the DatabaseDriver protocol #5544

Open jparise opened 3 months ago

jparise commented 3 months ago

Summary

This allows us to remove the DatabaseDriver.h header import, simplifying FlipperKitDatabasesPlugin.h's dependencies.

Changelog

Simplified FlipperKitDatabasesPlugin.h dependencies.

Test Plan

Successfully built the FlipperKitDatabasesPlugin plugin code

facebook-github-bot commented 3 months ago

Hi @jparise!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

jparise commented 3 months ago

Or was this intentionally imported as a way to implicitly pull DatabaseDriver.h into the public interface? I think that still isn't particularly helpful, depending on how you go about implementing a concrete driver.

facebook-github-bot commented 3 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!