facebook / flipper

A desktop debugging platform for mobile developers.
https://fbflipper.com/
MIT License
13.37k stars 953 forks source link

Skip hanging tests #5662

Closed antonk52 closed 3 months ago

antonk52 commented 3 months ago

A couple of tests have open handlers that cause jest to timeout in GitHub actions. Skipping these should fix the step to allow other jobs to run

Example failure

https://github.com/facebook/flipper/actions/runs/10083622244/job/27880598756#step:8:762

github-actions[bot] commented 3 months ago

Pull Request Test Coverage Report for Build 10147072360

Details


Files with Coverage Reduction New Missed Lines %
desktop/flipper-server/src/devices/ios/iOSCertificateProvider.tsx 3 14.13%
desktop/flipper-server/src/devices/ios/iOSCrashUtils.tsx 3 55.36%
desktop/flipper-server/src/devices/ServerDevice.tsx 6 8.33%
desktop/flipper-server/src/devices/ios/IOSDevice.tsx 7 14.12%
desktop/flipper-server/src/devices/ios/iOSLogListener.tsx 8 17.02%
desktop/flipper-server/src/devices/ios/iOSDeviceManager.tsx 21 21.43%
<!-- Total: 48 -->
Totals Coverage Status
Change from base Build 10114576751: -0.2%
Covered Lines: 8122
Relevant Lines: 15002

💛 - Coveralls
facebook-github-bot commented 3 months ago

@antonk52 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@antonk52 merged this pull request in facebook/flipper@5f4f25f3685debd76928e81c513a4188d2d274fd.