Replace `fs.rmdir` with `fs.rm`

[trivikr]

Is your request related to a problem? Please describe.

This project uses fs.rmdir with { recursive: true } which has been runtime deprecated since Node.js v16.0.0.

• Source code: https://github.com/facebook/flipper/blob/657e5b738cb8d2cf88c1c265b06bd047a6189d8a/desktop/flipper-server/src/devices/ios/IOSBridge.tsx#L251
• Docs: https://nodejs.org/api/deprecations.html#dep0147-fsrmdirpath--recursive-true-

Example code

import fs from "fs-extra";

const dir = "test";
await fs.mkdir(dir);
await fs.rmdir("test", { recursive: true });

Output

(node:93995) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)

Describe the solution you'd like

Replace fs.rmdir with fs.rm API call

Example code which does not thrown runtime warning

import fs from "fs-extra";

const dir = "test";
await fs.mkdir(dir);
await fs.rm("test", { recursive: true });

[antonk52]

Closed by https://github.com/facebook/flipper/commit/b819119b70a4be4fdbebdb3599d3e5c6f192f225