search

facebook / flow

Adds static typing to JavaScript to improve developer productivity and code quality.
https://flow.org/
MIT License
22.08k stars 1.85k forks source link

Suppress unused suppression errors after a library parse error. #3210

Open billschaller opened 7 years ago

billschaller commented 7 years ago

Today I screwed up a libdef such that it had a parse error. Flow reported that fine, but it also reported every suppression in my codebase as an unused suppression error. A fatal error early on in flow's process should suppress the Error suppressing comment. Unused suppression errors, as they're just noise.

rosskevin commented 7 years ago

Ugh, this is a huge problem. I have a libdef that validates in try flow yet fails in my usage, and this is covering up what I expect to be a pointer to the libdef problem.