Missing DOM HTML elements

[mislav]

These HTML element classes are defined in Google Chrome but missing from dom.js definitions:

• [x] HTMLAreaElement
• [x] HTMLBodyElement
• [ ] HTMLContentElement
• [x] HTMLDataListElement
• [x] HTMLDetailsElement
• [x] HTMLDialogElement
• [ ] HTMLDirectoryElement
• [x] HTMLFieldSetElement
• [ ] HTMLFontElement
• [ ] HTMLFrameElement
• [ ] HTMLFrameSetElement
• [x] HTMLHeadElement
• [x] HTMLHtmlElement
• [x] HTMLLegendElement
• [x] HTMLMapElement
• [ ] HTMLMarqueeElement
• [x] HTMLMeterElement
• [x] HTMLModElement
• [x] HTMLObjectElement
• [ ] HTMLOutputElement
• [x] HTMLParamElement
• [x] HTMLPictureElement
• [x] HTMLProgressElement
• [x] HTMLQuoteElement
• [ ] HTMLShadowElement
• [x] HTMLTableColElement
• [x] HTMLTitleElement
• [x] HTMLTrackElement

This list was generated with:

Object.getOwnPropertyNames(window).filter(n => /^HTML/.test(n)).join("\n")

[jschfflr]

@mislav I implemented the HTMLObjectElement class. Should I open a pull request?

[mislav]

@ghodir Always feel free to open a pull request!

Keep in mind that adding some tests for this could be useful. See existing tests/dom/*.js files. Re-run tests with make && ./runtests.sh bin/flow dom. Record new test expectations with ./runtests.sh -r bin/flow dom.

[mroch]

https://github.com/facebook/flow/commit/7b971fbd7b0ec8c66613459eac6cfd31a0237b26 added a bunch, I updated the checklist above

[mislav]

@mroch Fantastic; thank you

[romeovs]

HTMLSummaryElement is not on this list! Should I open a new issue or can we add it to this one?

[mislav]

@romeovs The spec suggests that <summary> does not have its own HTMLSummaryElement interface and that it instead uses HTMLElement https://html.spec.whatwg.org/multipage/interactive-elements.html#the-summary-element

Similarly, Google Chrome does not seem to have HTMLSummaryElement defined either.