search

facebook / flow

Adds static typing to JavaScript to improve developer productivity and code quality.
https://flow.org/
MIT License
22.07k stars 1.85k forks source link

TextDecoder.decode() should accept ArrayBuffer too #5156

Open goc9000 opened 6 years ago

goc9000 commented 6 years ago

The definition here:

https://github.com/facebook/flow/blob/9dfe1c367b7aee3407f272c9be6e0e1728c5f684/lib/bom.js#L1237

should be amended to:

decode(buffer?: ArrayBuffer | $ArrayBufferView, options?: { stream: bool }): string;

As per https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder , .decode() accepts either an ArrayBuffer or an ArrayBufferView.

mrkev commented 6 years ago

Feel free to PR!