Closed christianvuerings closed 1 year ago
We have fixed a number of segfaults in version 158, but it's possible there are still a few around. If possible do you think you could isolate a repro that you would be able to link in the form of a Github repo?
@dsainati1 is there a way to figure out what the root cause is when a segfault happens? Our codebase is +2 million lines of JS so it's tricky to know which file / import is causing the issue. Definitely willing to share a few files if we can pinpoint which ones cause the issue.
Also know that we ended up disabling experimental.refactor
which fixed the following issues:
Getting code actions
never stoppedDoes disabling refactor
also fix the segfault?
Does disabling
refactor
also fix the segfault?
@dsainati1 So far, yes, we are no longer seeing the segfault after setting experimental.refactor=false
in our flow config.
We will update this issue if we would end up seeing it again.
please reopen or file a new issue if this happens again!
We upgraded Flow from 0.152.0 to 0.158.0 and now we regularly see the server shutting down (every 10 to 15 minutes).
Flow version: 0.158.0 Node.js version: v14.15.4
Expected behavior
No regular shut down of the Flow server
Actual behavior
Flow occasionally shuts down, we see the following exception in the
monitor_log
: