search

facebook / flow

Adds static typing to JavaScript to improve developer productivity and code quality.
https://flow.org/
MIT License
22.09k stars 1.85k forks source link

[ci] Properly test mac and linux in GitHub Actions CI #9130

Closed SamChou19815 closed 3 months ago

SamChou19815 commented 3 months ago

Currently, the mac and linux tests are passing, but if we look at the logs, they are failing for every single test. It turns out that we are not even downloading the artifacts from previous build jobs. We also need to set the executable bit to actually make the tests runnable (this is not needed in circle ci jobs and also not needed for windows builds, so it's unclear why, which needs further investigation)

facebook-github-bot commented 3 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@SamChou19815 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

SamChou19815 commented 3 months ago

We also need to set the executable bit to actually make the tests runnable (this is not needed in circle ci jobs and also not needed for windows builds, so it's unclear why, which needs further investigation)

Note for myself:

https://github.com/actions/upload-artifact/issues/38

facebook-github-bot commented 3 months ago

@SamChou19815 merged this pull request in facebook/flow@b0efcf1e37dc82c4df2bb0966fdd7ddd1bebaf2f.