search

facebook / flow

Adds static typing to JavaScript to improve developer productivity and code quality.
https://flow.org/
MIT License
22.09k stars 1.85k forks source link

[flow][flow.js] Reintroduce back 4.14 stubs for js_of_ocaml for now #9159

Closed SamChou19815 closed 1 week ago

SamChou19815 commented 1 week ago

Summary: Here is my plan:

  1. Reintroduce this to unbreak OSS CI
  2. Use v0.238.1 to test out a CI workflow including automated releases with only github actions. Why? The circleci jobs use a very old container that's no longer compatible with ocaml 5, while https://github.com/facebook/flow/commit/14d1fd22ab148782a281b531701a8d14ccfe3120 makes it no longer an issue for github actions. Since we need to move away from circleci anyways, let's just do it now.
  3. Once everything is on github actions, make ocaml 5 build on github actions
  4. delete the stub again.

Changelog: [internal]

Differential Revision: D58677143

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D58677143

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D58677143

facebook-github-bot commented 1 week ago

This pull request has been merged in facebook/flow@4a825b9d3ec753d88a43bd7d0256e80fe384f6ec.