search

facebook / folly

An open-source C++ library developed and used at Facebook.
https://groups.google.com/forum/?fromgroups#!forum/facebook-folly
Apache License 2.0
28.4k stars 5.56k forks source link

Build fails on FreeBSD 11: error: unknown type name 'extent_hooks_t' #1458

Open yurivict opened 4 years ago

yurivict commented 4 years ago 
/wrkdirs/usr/ports/devel/folly/work/folly-2020.09.14.00/folly/experimental/JemallocHugePageAllocator.cpp:92:7: error: unknown type name 'extent_hooks_t'
      extent_hooks_t* extent,
      ^
/wrkdirs/usr/ports/devel/folly/work/folly-2020.09.14.00/folly/experimental/JemallocHugePageAllocator.cpp:103:3: error: unknown type name 'extent_alloc_t'
  extent_alloc_t* originalAlloc_{nullptr};
  ^
/wrkdirs/usr/ports/devel/folly/work/folly-2020.09.14.00/folly/experimental/JemallocHugePageAllocator.cpp:104:3: error: unknown type name 'extent_hooks_t'
  extent_hooks_t extentHooks_;
  ^

Something wrong with JEMALLOC_* ifdefs.

Log: http://beefy9.nyi.freebsd.org/data/113amd64-default/549547/logs/folly-2020.09.14.00.log

Orvid commented 4 years ago

Folly's handling of jemalloc hasn't changed (absent a single change today that will allow some overriding for some internal uses) in many months. Folly is supposed to be getting its JEMalloc declarations from malloc_np.h on FreeBSD, has something changed in how that's exposing them?

yurivict commented 4 years ago

The folly port only exists on FreeBSD for a few months, and it has likely always been failing on FreeBSD 11.