search

facebook / folly

An open-source C++ library developed and used at Facebook.
https://groups.google.com/forum/?fromgroups#!forum/facebook-folly
Apache License 2.0
28.29k stars 5.55k forks source link

Most of the tests do not run (intentially?) #1664

Open kvtb opened 3 years ago

kvtb commented 3 years ago

It smells Volkswagen here: after https://github.com/facebook/folly/commit/4033d186108b5bca4f7347fa0c364eb3a0e9cbab most of the tests - which are not BROKEN SLOW or HANGING and thus have empty string as the tag - are always skipped and do not run.

kvtb commented 3 years ago

Also, there is much more *Test.cpp files than tests in CMakeLists.txt. Many tests do not run because they are not in CMakeLists.txt.