search

facebook / folly

An open-source C++ library developed and used at Facebook.
https://groups.google.com/forum/?fromgroups#!forum/facebook-folly
Apache License 2.0
28.36k stars 5.56k forks source link

Support glog 0.7.0 #2171

Open chenrui333 opened 7 months ago

chenrui333 commented 7 months ago

👋 trying to build fizz with glog 0.7.0, but ran into some regression test failure as below:

  ==> /usr/bin/clang++ -std=c++17 test.cpp -o test -I/opt/homebrew/Cellar/fizz/2024.04.01.00_1/include -I/opt/homebrew/opt/openssl@3/include -L/opt/homebrew/Cellar/fizz/2024.04.01.00_1/lib -lfizz -L/opt/homebrew/opt/folly/lib -lfolly -L/opt/homebrew/opt/gflags/lib -lgflags -L/opt/homebrew/opt/glog/lib -lglog -L/opt/homebrew/opt/libevent/lib -levent -L/opt/homebrew/opt/libsodium/lib -lsodium -L/opt/homebrew/opt/openssl@3/lib -lcrypto -lssl
  In file included from test.cpp:1:
  In file included from /opt/homebrew/Cellar/fizz/2024.04.01.00_1/include/fizz/client/AsyncFizzClient.h:11:
  In file included from /opt/homebrew/Cellar/fizz/2024.04.01.00_1/include/fizz/client/ClientExtensions.h:11:
  In file included from /opt/homebrew/Cellar/fizz/2024.04.01.00_1/include/fizz/record/Types.h:12:
  In file included from /opt/homebrew/include/folly/io/Cursor.h:31:
  In file included from /opt/homebrew/include/folly/io/IOBuf.h:33:
  /opt/homebrew/include/glog/logging.h:60:4: error: <glog/logging.h> was not included correctly. See the documention for how to consume the library.
  #  error <glog/logging.h> was not included correctly. See the documention for how to consume the library.
     ^

same failure seen for wangle as well.

relates to https://github.com/Homebrew/homebrew-core/pull/163094

nh2 commented 4 months ago

Looks like Arch Linux AUR has a fix for this:

https://aur.archlinux.org/cgit/aur.git/tree/fix-cmake-find-glog.patch?h=folly

nh2 commented 4 months ago

With PR #2245 and the above mentioned AUR patch, folly builds with glog 0.7.1 on NixOS.