facebook / hermes

A JavaScript engine optimized for running React Native.
https://hermesengine.dev/
MIT License
9.87k stars 633 forks source link

Hermes Issue with expo-cli? JavaScript engine configuration is inconsistent between app.json and Android native project #1041

Closed justinmooresystem1 closed 1 year ago

justinmooresystem1 commented 1 year ago

I am trying to expo publish my Android app and am getting the following error:

Finished building JavaScript bundle in 45823ms.
JavaScript engine configuration is inconsistent between app.json and Android native project.
In app.json: Hermes is not enabled
In Android native project: Hermes is enabled
Please check the following files for inconsistencies:
  - packages/info-expo/app.json
  - packages/info-expo/android/gradle.properties
  - packages/info-expo/android/app/build.gradle

Here is my package.json

"dependencies": {
    "@react-native-async-storage/async-storage": "~1.15.0",
    "@react-native-community/netinfo": "6.0.0",
    "@react-native-community/voice": "1.1.4",
    "@react-native-firebase/analytics": "7.6.4",
    "@react-native-firebase/app": "8.4.3",
    "@react-native-masked-view/masked-view": "0.2.4",
    "@react-navigation/core": "^6.4.8",
    "@react-navigation/material-top-tabs": "6.0.0",
    "@react-navigation/native": "6.0.0",
    "@react-navigation/stack": "6.0.0",
    "@reduxjs/toolkit": "^1.3.6",
    "@rnhooks/keyboard": "0.0.3",
    "@s1/dpl": "3.0.17",
    "@unimodules/core": "~7.1.1",
    "change-case": "^4.1.1",
    "eas-cli": "^3.14.0",
    "escape-string-regexp": "2.0.0",
    "expo": "^42.0.0",
    "expo-application": "~3.2.0",
    "expo-asset": "~8.3.3",
    "expo-av": "~9.2.3",
    "expo-constants": "~11.0.1",
    "expo-intent-launcher": "~9.1.0",
    "expo-localization": "~10.2.0",
    "expo-network": "~3.2.0",
    "expo-splash-screen": "~0.11.2",
    "expo-updates": "~0.8.2",
    "i18next": "^19.4.4",
    "react": "16.13.1",
    "react-dom": "16.13.1",
    "react-i18next": "^11.4.0",
    "react-is": "^18.2.0",
    "react-native": "0.63.4",
    "react-native-device-info": "5.5.8",
    "react-native-gesture-handler": "~1.10.2",
    "react-native-offline": "^6.0.0",
    "react-native-pager-view": "5.0.12",
    "react-native-paper": "4.2.0",
    "react-native-reanimated": "~2.2.0",
    "react-native-responsive-dimensions": "^3.1.1",
    "react-native-safe-area-context": "3.2.0",
    "react-native-screens": "~3.4.0",
    "react-native-startup-time": "^1.2.2",
    "react-native-svg": "12.1.1",
    "react-native-tab-view": "3.0.0",
    "react-native-unimodules": "~0.14.5",
    "react-native-url-polyfill": "^1.1.2",
    "react-native-vector-icons": "^6.6.0",
    "react-native-web": "~0.13.12",
    "react-native-webview": "11.6.2",
    "react-redux": "^7.2.0",
    "redux": "^4.0.5",
    "redux-devtools-extension": "^2.13.8",
    "redux-persist": "^6.0.2",
    "redux-thunk": "^2.3.0",
    "styled-components": "^5.1.0",
    "url-regex": "^5.0.0"
  },
  "devDependencies": {
    "@babel/core": "~7.9.0",
    "@babel/plugin-transform-async-to-generator": "7.10.1",
    "@carimus/metro-symlinked-deps": "1.1.0",
    "@google-cloud/translate": "^5.1.4",
    "@testing-library/react-hooks": "3.2.1",
    "@testing-library/react-native": "5.0.3",
    "@types/jest": "^25.2.3",
    "@types/node": "^14.0.4",
    "@types/react": "~16.9.35",
    "@types/react-native": "~0.63.2",
    "@types/react-native-responsive-dimensions": "3.0.0",
    "@types/react-redux": "^7.1.6",
    "@types/react-test-renderer": "^16.9.1",
    "@types/styled-components": "^4.4.2",
    "@types/yargs": "13.0.4",
    "aws-sdk": "^2.671.0",
    "babel-preset-expo": "8.3.0",
    "eslint": "6.8.0",
    "expo-cli": "4.9",
    "expo-optimize": "^0.1.23",
    "expo-web-browser": "~9.2.0",
    "jest-expo": "^42.0.1",
    "npm-run-all": "4.1.5",
    "react-native-svg-transformer": "^0.14.3",
    "react-native-testing-library": "^1.12.0",
    "react-test-renderer": "16.10.1",
    "sharp-cli": "^1.10.0",
    "shelljs": "^0.8.3",
    "ts-jest": "^26.0.0",
    "typescript": "~4.0.0",
    "webpack": "^4.43.0",
    "webpack-dev-server": "^3.10.3",
    "yargs": "15.0.2"
  }

Here is my app.json

{
    "expo": {
        "owner": "REDACTED",
        "name": "info-expo",
        "slug": "info-expo",
        "privacy": "unlisted",
        "packagerOpts": {
            "config": "metro.config.js",
            "sourceExts": ["js", "jsx", "ts", "tsx", "svg"]
        },
        "platforms": ["ios", "android", "web"],
        "version": "1.1.9660",
        "orientation": "portrait",
        "icon": "./assets/icon.png",
        "splash": {
            "image": "./assets/splash.png",
            "resizeMode": "contain",
            "backgroundColor": "#ffffff"
        },
        "updates": {
            "enabled": true,
            "checkAutomatically": "ON_LOAD",
            "fallbackToCacheTimeout": 0
        },
        "assetBundlePatterns": ["**/*"],
        "ios": {
            "supportsTablet": true
        },
        "scheme": "info",
        "android": {
            "package": "REDACTED",
            "intentFilters": [
                {
                    "action": "VIEW",
                    "data": [
                        {
                            "scheme": "info://"
                        }
                    ],
                    "category": ["BROWSABLE", "DEFAULT"]
                }
            ],
            "versionCode": 1576717578
        }
    },
    "name": "REDACTED"
}

Here is my gradle.properties

android.useAndroidX=true
android.enableJetifier=true
org.gradle.daemon=true
org.gradle.configureondemand=true
org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=2048m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8

# Version of flipper SDK to use with React Native
FLIPPER_VERSION=0.54.0

Here is my app/build.gradle


apply plugin: "com.android.application"
apply plugin: 'kotlin-android'
apply plugin: 'com.google.gms.google-services'

import com.android.build.OutputFile

/**
 * The react.gradle file registers a task for each build variant (e.g. bundleDebugJsAndAssets
 * and bundleReleaseJsAndAssets).
 * These basically call `react-native bundle` with the correct arguments during the Android build
 * cycle. By default, bundleDebugJsAndAssets is skipped, as in debug/dev mode we prefer to load the
 * bundle directly from the development server. Below you can see all the possible configurations
 * and their defaults. If you decide to add a configuration block, make sure to add it before the
 * `apply from: "../../node_modules/react-native/react.gradle"` line.
 *
 * project.ext.react = [
 *   // the name of the generated asset file containing your JS bundle
 *   bundleAssetName: "index.android.bundle",
 *
 *   // the entry file for bundle generation
 *   entryFile: "index.android.js",
 *
 *   // https://reactnative.dev/docs/performance#enable-the-ram-format
 *   bundleCommand: "ram-bundle",
 *
 *   // whether to bundle JS and assets in debug mode
 *   bundleInDebug: false,
 *
 *   // whether to bundle JS and assets in release mode
 *   bundleInRelease: true,
 *
 *   // whether to bundle JS and assets in another build variant (if configured).
 *   // See http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Build-Variants
 *   // The configuration property can be in the following formats
 *   //         'bundleIn${productFlavor}${buildType}'
 *   //         'bundleIn${buildType}'
 *   // bundleInFreeDebug: true,
 *   // bundleInPaidRelease: true,
 *   // bundleInBeta: true,
 *
 *   // whether to disable dev mode in custom build variants (by default only disabled in release)
 *   // for example: to disable dev mode in the staging build type (if configured)
 *   devDisabledInStaging: true,
 *   // The configuration property can be in the following formats
 *   //         'devDisabledIn${productFlavor}${buildType}'
 *   //         'devDisabledIn${buildType}'
 *
 *   // the root of your project, i.e. where "package.json" lives
 *   root: "../../",
 *
 *   // where to put the JS bundle asset in debug mode
 *   jsBundleDirDebug: "$buildDir/intermediates/assets/debug",
 *
 *   // where to put the JS bundle asset in release mode
 *   jsBundleDirRelease: "$buildDir/intermediates/assets/release",
 *
 *   // where to put drawable resources / React Native assets, e.g. the ones you use via
 *   // require('./image.png')), in debug mode
 *   resourcesDirDebug: "$buildDir/intermediates/res/merged/debug",
 *
 *   // where to put drawable resources / React Native assets, e.g. the ones you use via
 *   // require('./image.png')), in release mode
 *   resourcesDirRelease: "$buildDir/intermediates/res/merged/release",
 *
 *   // by default the gradle tasks are skipped if none of the JS files or assets change; this means
 *   // that we don't look at files in android/ or ios/ to determine whether the tasks are up to
 *   // date; if you have any other folders that you want to ignore for performance reasons (gradle
 *   // indexes the entire tree), add them here. Alternatively, if you have JS files in android/
 *   // for example, you might want to remove it from here.
 *   inputExcludes: ["android/**", "ios/**"],
 *
 *   // override which node gets called and with what additional arguments
 *   nodeExecutableAndArgs: ["node"],
 *
 *   // supply additional arguments to the packager
 *   extraPackagerArgs: []
 * ]
 */

project.ext.react = [
    entryFile: "index.js",
    enableHermes: true,
    bundleInRelease: true,
    bundleInStage: true,
    bundleInDebug: false,
    devDisabledInStage: false
]

apply from: '../../node_modules/react-native-unimodules/gradle.groovy'
apply from: "../../node_modules/react-native/react.gradle"
apply from: "../../node_modules/expo-updates/scripts/create-manifest-android.gradle"

/**
 * Set this to true to create two separate APKs instead of one:
 *   - An APK that only works on ARM devices
 *   - An APK that only works on x86 devices
 * The advantage is the size of the APK is reduced by about 4MB.
 * Upload all the APKs to the Play Store and people will download
 * the correct one based on the CPU architecture of their device.
 */
def enableSeparateBuildPerCPUArchitecture = false

/**
 * Run Proguard to shrink the Java bytecode in release builds.
 */
def enableProguardInReleaseBuilds = false

/**
 * The preferred build flavor of JavaScriptCore.
 *
 * For example, to use the international variant, you can use:
 * `def jscFlavor = 'org.webkit:android-jsc-intl:+'`
 *
 * The international variant includes ICU i18n library and necessary data
 * allowing to use e.g. `Date.toLocaleString` and `String.localeCompare` that
 * give correct results when using with locales other than en-US.  Note that
 * this variant is about 6MiB larger per architecture than default.
 */
def jscFlavor = 'org.webkit:android-jsc:+'

/**
 * Whether to enable the Hermes VM.
 *
 * This should be set on project.ext.react and mirrored here.  If it is not set
 * on project.ext.react, JavaScript will not be compiled to Hermes Bytecode
 * and the benefits of using Hermes will therefore be sharply reduced.
 */
def enableHermes = project.ext.react.get("enableHermes", true);

// versionCode has to be greater than the original Java version of the app and less than 2100000000
// https://developer.android.com/studio/publish/versioning.html#appversioning
def appVersionCode = 1911111109 + Integer.valueOf(System.env.BUILD_NUMBER ?: 0)

def safeExtGet(prop, fallback) {
    rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

def safePropGet(prop, fallback) {
    project.hasProperty(prop) ? project.findProperty(prop) : fallback
}

android {
    compileSdkVersion 31

    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }

    dexOptions {
        javaMaxHeapSize "3g"
    }

    defaultConfig {
        applicationId 'info.com.pwa'
        minSdkVersion rootProject.ext.minSdkVersion
        targetSdkVersion rootProject.ext.targetSdkVersion
        versionCode safePropGet("versionCode", appVersionCode) as Integer
        versionName safePropGet("versionName", "1.0.0")
    }
    splits {
        abi {
            reset()
            enable enableSeparateBuildPerCPUArchitecture
            universalApk false  // If true, also generate a universal APK
            include "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
        }
    }
    signingConfigs {
        debug {
            storeFile file('debug.keystore')
            storePassword 'android'
            keyAlias 'androiddebugkey'
            keyPassword 'android'
        }
        release {
            storeFile file(System.getenv("ANDROID_KEYSTORE_PATH") ?: "../../info-expo.jks")
            storePassword 'systemone'
            keyAlias 'info'
            keyPassword 'systemone'
        }
    }
    buildTypes {
        debug {
            signingConfig signingConfigs.debug
            applicationIdSuffix = ".debug"
        }
        release {
            minifyEnabled enableProguardInReleaseBuilds
            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
            consumerProguardFiles 'proguard-rules.pro'
            signingConfig signingConfigs.release
        }
        stage {
            initWith release
            buildConfigField("String", "RELEASE_CHANNEL", "\"stage\"")
            manifestPlaceholders = [stage: true]
            matchingFallbacks = ['release']
            signingConfig signingConfigs.debug
        }
    }

    configurations.all {
        resolutionStrategy {
            force "com.facebook.soloader:soloader:0.10.4"
        }
    }

    // applicationVariants are e.g. debug, release
    applicationVariants.all { variant ->
        variant.outputs.each { output ->
            // For each separate APK per architecture, set a unique version code as described here:
            // https://developer.android.com/studio/build/configure-apk-splits.html
            def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4]
            def abi = output.getFilter(OutputFile.ABI)
            if (abi != null) {  // null for the universal-debug, universal-release variants
                output.versionCodeOverride =
                        versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
            }

        }
    }
}

dependencies {
    implementation fileTree(dir: "libs", include: ["*.jar"])
    implementation "com.facebook.react:react-native:+"  // From node_modules
    addUnimodulesDependencies()

    // non-unimodule dependencies
    implementation 'androidx.appcompat:appcompat:1.1.0'
    implementation 'com.google.android.play:core:1.7.0'
    implementation 'com.jakewharton.timber:timber:4.7.1'
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlinVersion"
    implementation "androidx.swiperefreshlayout:swiperefreshlayout:1.0.0"

    if (enableHermes) {
        def hermesPath = "../../node_modules/hermes-engine/android/";
        debugImplementation files(hermesPath + "hermes-debug.aar")
        stageImplementation files(hermesPath + "hermes-release.aar")
        releaseImplementation files(hermesPath + "hermes-release.aar")
    } else {
        implementation jscFlavor
    }
}

// Run this once to be able to run the application with BUCK
// puts all compile dependencies into folder libs for BUCK to use
task copyDownloadableDepsToLibs(type: Copy) {
    from configurations.compile
    into 'libs'
}

apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)

There are few mentions of this error online, but from what I could tell it had to do with expo-cli being out of date or something unknown with hermes. My version of expo-cli=4.9 is the correct version for my expo=42 app and my hermes-engine=0.5.1 is the correct version for react-native=0.63.4. Any ideas on what this could be stemming from? You can see two other posts of people having this issue here and here

mattbfb commented 1 year ago

@justinmooresystem1 This looks like an issue with Expo project configuration, as opposed to an issue with Hermes.

The error you posted indicates

In app.json: Hermes is not enabled
In Android native project: Hermes is enabled

It looks like the Expo docs list a way to enable Hermes in app.json using the jsEngine property: https://docs.expo.dev/guides/using-hermes/

That being said, I am not familiar with Expo configurations, so I can't say whether the correct solution is to just add that line, or to re-generate the project using different settings in the CLI tool. The Expo team can probably offer more insight into this. Hermes doesn't generate or consume these config files.

mattbfb commented 1 year ago

This doesn't appear to be a Hermes issue. Feel free to reopen if there is new information to investigate.