facebook / hermes

A JavaScript engine optimized for running React Native.

https://hermesengine.dev/

MIT License

9.41k stars 596 forks source link

Fix README Logo Image #1373

Closed ykws closed 4 weeks ago

ykws commented 1 month ago

Summary

I have fixed the logo image path in the README. Upon checking the previously specified path ./website/static/img/logo.svg, I found that it was last available up to the tag v0.12.0. I have retrieved the logo image from this commit, re-uploaded it, and corrected the path in the README.

The logo is now located at doc/img. If a different location is preferred for this file, please let me know, and I can adjust it accordingly.

You can view the corrected logo file here: https://github.com/facebook/hermes/blob/v0.12.0/website/static/img/logo.svg

Test Plan

Please review the changes in the README file on this pull request branch. The screenshot labeled "After" below provides evidence of the modifications made.

Before	After

facebook-github-bot commented 1 month ago

Hi @ykws!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

tmikov commented 1 month ago

Thank you, that was a nice catch!

ykws commented 1 month ago

I have previously submitted this pull request and I am pleased to inform you that I have now signed the Contributor License Agreement (CLA).

facebook-github-bot commented 1 month ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 4 weeks ago

@tmikov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 4 weeks ago

@tmikov merged this pull request in facebook/hermes@ce90d24b45f93e5f87c91c684ee6d634d42743ba.