search

facebook / hermes

A JavaScript engine optimized for running React Native.
https://hermesengine.dev/
MIT License
9.41k stars 596 forks source link

Emit executionContextCreated notification from hcdp #1378

Closed dannysu closed 3 weeks ago

dannysu commented 3 weeks ago

Summary: Without emitting the Runtime.executionContextCreated notification, Chrome DevTools' Console tab doesn't work.

Adding code to intercept Runtime.enable and emit execution context information. Also added handler for console.log. This way we can exercise the ConsoleMessage-related code paths without using RN.

Reviewed By: mattbfb

Differential Revision: D56337202

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D56337202

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D56337202

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D56337202

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D56337202

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D56337202

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D56337202

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D56337202

facebook-github-bot commented 3 weeks ago

This pull request has been merged in facebook/hermes@6285c8be11d22c30997e84b0cb8087bce127f1d6.