search

facebook / hermes

A JavaScript engine optimized for running React Native.
https://hermesengine.dev/
MIT License
9.75k stars 625 forks source link

using TextDecoder with hermes #1403

Open davidliu opened 4 months ago

davidliu commented 4 months ago

Problem

TextEncoder was recently added with 3863a36a53005dd1e6d39ea0d4ef5573bafde910 (related issue #948), but there doesn't seem to be a TextDecoder added. It seems odd that the encoder was added without the related decoder.

Solution

Add TextDecoder to hermes.

Badbird5907 commented 1 month ago

Hi, is this planned?

tmikov commented 1 month ago

It is planned, but not very high priority. PRs are welcome.

gituser8796 commented 1 month ago

hi @tmikov is there a plan to release a TextDecoder?

mabasic commented 2 weeks ago

Having this issue in react-native 0.74. Workaround is to use import 'fast-text-encoder in every layout which uses an import which deals with TextDecoder.

Is there a fix for this in the near future? I have seen the cpp code for TextEncoder and there is no way for me to contribute to this with my knowledge of cpp. I'm using Effect HttpClient which uses TextDecoder.

aretrace commented 2 days ago

Eagerly awaiting for TextDecoder 🧘