facebook / hermes

A JavaScript engine optimized for running React Native.
https://hermesengine.dev/
MIT License
9.63k stars 616 forks source link

Failed to transform file 'hermes-debug.aar' to match attributes {artifactType=android-manifest} #142

Closed Maskedman99 closed 4 years ago

Maskedman99 commented 4 years ago

I am trying to enable hermes in my app as per the instruction given in https://facebook.github.io/react-native/docs/hermes . After following the instructions, when I try to run my app I get the following error.

      FAILURE: Build failed with an exception.

     * What went wrong:
     Execution failed for task ':app:preDebugBuild'.
     > Could not resolve all files for configuration ':app:debugCompileClasspath'.
     > Failed to transform file 'hermes-debug.aar' to match attributes {artifactType=android-manifest}
     > Execution failed for JetifyTransform: /X/Y/K/J/App/node_modules/hermesvm/android/hermes-debug.aar.
     > Failed to transform '/X/Y/K/J/App/node_modules/hermesvm/android/hermes-debug.aar' using Jetifier. Reason: Cannot open a library at 'FileMapping(from=/X/Y/K/J/App/node_modules/hermesvm/android/hermes-debug.aar, to=/X/Y/.gradle/caches/transforms-2/files-2.1/8e20282fcbd8d20332fe90712dcd6d61/jetified-hermes-debug.aar)'.(Run with --stacktrace for more details.)

My build.gradle

     .............
      project.ext.react = [
         entryFile: "index.js",
         enableHermes: true,  // clean and rebuild if changing
      ]
      def enableProguardInReleaseBuilds = false
      def enableSeparateBuildPerCPUArchitecture = true
      def enableHermes = project.ext.react.get("enableHermes", true);
      .............
      dependencies {
           implementation fileTree(dir: "libs", include: ["*.jar"])
           implementation "com.facebook.react:react-native:+"  // From node_modules

           if (enableHermes) {
               def hermesPath = "../../node_modules/hermesvm/android/";
               debugImplementation files(hermesPath + "hermes-debug.aar")
               releaseImplementation files(hermesPath + "hermes-release.aar")
            } else {
               implementation jscFlavor
              }
      }
Maskedman99 commented 4 years ago

O.K. solved it by creating a new app and enabling hermes in that one and it worked, so I compared the build.gradle files of both and found out

               def hermesPath = "../../node_modules/hermes-engine/android/"; 

is used in if(enableHermes) instead "../../node_modules/hermesvm/android/" . Wondering why they didn't mention this in the getting started documents.

dulinriley commented 4 years ago

Yes this is probably related to us renaming our npm package from hermesvm to hermes-engine. It doesn't look the documentation specifically mentions hermesvm though, so maybe it was an update somewhere else that fixed it?

inceabdullah commented 4 years ago

The same error. After changing hermesvm to hermes-engine in build.gradl but right now just crash.

react-native: 0.61.5

my build.gradle:

apply plugin: "com.android.application"
apply plugin: "com.google.firebase.firebase-perf"
apply plugin: 'io.fabric'

import com.android.build.OutputFile

/**
 * The react.gradle file registers a task for each build variant (e.g. bundleDebugJsAndAssets
 * and bundleReleaseJsAndAssets).
 * These basically call `react-native bundle` with the correct arguments during the Android build
 * cycle. By default, bundleDebugJsAndAssets is skipped, as in debug/dev mode we prefer to load the
 * bundle directly from the development server. Below you can see all the possible configurations
 * and their defaults. If you decide to add a configuration block, make sure to add it before the
 * `apply from: "../../node_modules/react-native/react.gradle"` line.
 *
 * project.ext.react = [
 *   // the name of the generated asset file containing your JS bundle
 *   bundleAssetName: "index.android.bundle",
 *
 *   // the entry file for bundle generation
 *   entryFile: "index.android.js",
 *
 *   // https://facebook.github.io/react-native/docs/performance#enable-the-ram-format
 *   bundleCommand: "ram-bundle",
 *
 *   // whether to bundle JS and assets in debug mode
 *   bundleInDebug: false,
 *
 *   // whether to bundle JS and assets in release mode
 *   bundleInRelease: true,
 *
 *   // whether to bundle JS and assets in another build variant (if configured).
 *   // See http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Build-Variants
 *   // The configuration property can be in the following formats
 *   //         'bundleIn${productFlavor}${buildType}'
 *   //         'bundleIn${buildType}'
 *   // bundleInFreeDebug: true,
 *   // bundleInPaidRelease: true,
 *   // bundleInBeta: true,
 *
 *   // whether to disable dev mode in custom build variants (by default only disabled in release)
 *   // for example: to disable dev mode in the staging build type (if configured)
 *   devDisabledInStaging: true,
 *   // The configuration property can be in the following formats
 *   //         'devDisabledIn${productFlavor}${buildType}'
 *   //         'devDisabledIn${buildType}'
 *
 *   // the root of your project, i.e. where "package.json" lives
 *   root: "../../",
 *
 *   // where to put the JS bundle asset in debug mode
 *   jsBundleDirDebug: "$buildDir/intermediates/assets/debug",
 *
 *   // where to put the JS bundle asset in release mode
 *   jsBundleDirRelease: "$buildDir/intermediates/assets/release",
 *
 *   // where to put drawable resources / React Native assets, e.g. the ones you use via
 *   // require('./image.png')), in debug mode
 *   resourcesDirDebug: "$buildDir/intermediates/res/merged/debug",
 *
 *   // where to put drawable resources / React Native assets, e.g. the ones you use via
 *   // require('./image.png')), in release mode
 *   resourcesDirRelease: "$buildDir/intermediates/res/merged/release",
 *
 *   // by default the gradle tasks are skipped if none of the JS files or assets change; this means
 *   // that we don't look at files in android/ or ios/ to determine whether the tasks are up to
 *   // date; if you have any other folders that you want to ignore for performance reasons (gradle
 *   // indexes the entire tree), add them here. Alternatively, if you have JS files in android/
 *   // for example, you might want to remove it from here.
 *   inputExcludes: ["android/**", "ios/**"],
 *
 *   // override which node gets called and with what additional arguments
 *   nodeExecutableAndArgs: ["node"],
 *
 *   // supply additional arguments to the packager
 *   extraPackagerArgs: []
 * ]
 */

project.ext.react = [
    entryFile: "index.js",
    enableHermes: true,  // clean and rebuild if changing
    hermesCommand: "../../node_modules/hermesvm/%OS-BIN%/hermes",

    // Sometimes (like if you use Android API<17) adb forwards don't work, so you need a bundle in the dev APK
    bundleInDebug: project.hasProperty("bundleInDebug") ? project.getProperty("bundleInDebug") : false,
]

apply from: "../../node_modules/react-native/react.gradle"
//apply from: "./react.gradle"

/**
 * Set this to true to create two separate APKs instead of one:
 *   - An APK that only works on ARM devices
 *   - An APK that only works on x86 devices
 * The advantage is the size of the APK is reduced by about 4MB.
 * Upload all the APKs to the Play Store and people will download
 * the correct one based on the CPU architecture of their device.
 */
def enableSeparateBuildPerCPUArchitecture = true

/**
 * Run Proguard to shrink the Java bytecode in release builds.
 */
def enableProguardInReleaseBuilds = false

/**
 * The preferred build flavor of JavaScriptCore.
 *
 * For example, to use the international variant, you can use:
 * `def jscFlavor = 'org.webkit:android-jsc-intl:+'`
 *
 * The international variant includes ICU i18n library and necessary data
 * allowing to use e.g. `Date.toLocaleString` and `String.localeCompare` that
 * give correct results when using with locales other than en-US.  Note that
 * this variant is about 6MiB larger per architecture than default.
 */
def jscFlavor = 'org.webkit:android-jsc:+'

/**
 * Whether to enable the Hermes VM.
 *
 * This should be set on project.ext.react and mirrored here.  If it is not set
 * on project.ext.react, JavaScript will not be compiled to Hermes Bytecode
 * and the benefits of using Hermes will therefore be sharply reduced.
 */
def enableHermes = project.ext.react.get("enableHermes", false);

android {   
    compileSdkVersion rootProject.ext.compileSdkVersion

    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }

    defaultConfig {
        applicationId "com.habertellali.tr"
        minSdkVersion rootProject.ext.minSdkVersion
        targetSdkVersion rootProject.ext.targetSdkVersion
        versionCode 1
        versionName "1.0"

        // Needed to support API<21, though there is a small chance proguard shrinks things sufficiently
        multiDexEnabled true
    }
    signingConfigs {
        debug {
            storeFile file('android.keystore')
            storePassword 'android'
            keyAlias 'androidkey'
            keyPassword 'android'
        }
        release {
            if (project.hasProperty('MYAPP_UPLOAD_STORE_FILE')) {
                storeFile file(MYAPP_UPLOAD_STORE_FILE)
                storePassword MYAPP_UPLOAD_STORE_PASSWORD
                keyAlias MYAPP_UPLOAD_KEY_ALIAS
                keyPassword MYAPP_UPLOAD_KEY_PASSWORD
            }
        }
    }
    splits {
        abi {
            reset()
            enable enableSeparateBuildPerCPUArchitecture
            universalApk false  // If true, also generate a universal APK
            include "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
        }
    }
    buildTypes {
        debug {
            signingConfig signingConfigs.debug
        }
        release {
            // Caution! In production, you need to generate your own keystore file.
            // see https://facebook.github.io/react-native/docs/signed-apk-android.

            signingConfig signingConfigs.debug
            minifyEnabled enableProguardInReleaseBuilds
            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
            signingConfig signingConfigs.release
        }
    }
    // applicationVariants are e.g. debug, release
    applicationVariants.all { variant ->
        variant.outputs.each { output ->
            // For each separate APK per architecture, set a unique version code as described here:
            // https://developer.android.com/studio/build/configure-apk-splits.html
            def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4]
            def abi = output.getFilter(OutputFile.ABI)
            if (abi != null) {  // null for the universal-debug, universal-release variants
                output.versionCodeOverride =
                        versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
            }
        }
    }
    packagingOptions {
        pickFirst '**/armeabi-v7a/libc++_shared.so'
        pickFirst '**/x86/libc++_shared.so'
        pickFirst '**/arm64-v8a/libc++_shared.so'
        pickFirst '**/x86_64/libc++_shared.so'
        pickFirst '**/x86/libjsc.so'
        pickFirst '**/armeabi-v7a/libjsc.so'
    }
}

dependencies {
    implementation project(':@react-native-community_netinfo')
    implementation project(':react-native-network-info')
    implementation project(':react-native-tcp')
    implementation fileTree(dir: "libs", include: ["*.jar"])
    implementation "com.facebook.react:react-native:+"  // From node_modules

    /* ----------------------------
    *    REACT NATIVE FIREBASE
    * ---------------------------- */

    // Firebase bom setup
    implementation platform("com.google.firebase:firebase-bom:22.2.0")

    // Required dependencies
    //noinspection GradleCompatible
    implementation "com.google.firebase:firebase-core"

    /* -------------------------
    *   OPTIONAL FIREBASE SDKS
    * ------------------------- */

    implementation('com.google.firebase:firebase-ads') {
      // exclude `customtabs` as the support lib version is out of date
      // we manually add it as a dependency below with a custom version
      exclude group: 'com.android.support', module: 'customtabs'
    }

    // Authentication
    implementation "com.google.firebase:firebase-auth"
    // Analytics
    implementation "com.google.firebase:firebase-analytics"
    // Performance Monitoring
    implementation "com.google.firebase:firebase-perf"
    // Remote Config
    implementation "com.google.firebase:firebase-config"
    // Cloud Storage
    implementation "com.google.firebase:firebase-storage"
    // Dynamic Links
    implementation "com.google.firebase:firebase-dynamic-links"
    // Real-time Database
    implementation "com.google.firebase:firebase-database"
    // Cloud Functions
    implementation "com.google.firebase:firebase-functions"
    // Cloud Firestore
    implementation "com.google.firebase:firebase-firestore"
    // Cloud Messaging / FCM
    implementation "com.google.firebase:firebase-messaging"
    // Crashlytics
    implementation('com.crashlytics.sdk.android:crashlytics@aar') {
        transitive = true
    }

    /* --------------------------------
    *  OPTIONAL SUPPORT LIBS
    * -------------------------------- */

    // Needed to support API<21, though there is a small chance proguard shrinks things sufficiently
    implementation "androidx.multidex:multidex:2.0.1"

    // For Firebase Ads
    //noinspection GradleCompatible
    implementation "com.android.support:customtabs:28.0.0"

    // For React Native Firebase Notifications
    implementation 'me.leolin:ShortcutBadger:1.1.22@aar'

    if (enableHermes) {
      def hermesPath = "../../node_modules/hermes-engine/android/";
      debugImplementation files(hermesPath + "hermes-debug.aar")
      releaseImplementation files(hermesPath + "hermes-release.aar")
    } else {
      implementation jscFlavor
    }
    //implementation ('com.google.android.gms:play-services-ads:18.+') { force = true; }
    compile ("com.facebook.react:react-native:0.61.5") { force = true } 
}

// Run this once to be able to run the application with BUCK
// puts all compile dependencies into folder libs for BUCK to use
task copyDownloadableDepsToLibs(type: Copy) {
    from configurations.compile
    into 'libs'
}

apply plugin: 'com.google.gms.google-services'

apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)
dulinriley commented 4 years ago

@inceabdullah I think the issue is here:

project.ext.react = [
    ...
    hermesCommand: "../../node_modules/hermesvm/%OS-BIN%/hermes",
    ...
]

Trying changing that path to "../../node_modules/hermes-engine/%OS-BIN%/hermes"

bandojulio commented 4 years ago

O.K. solved it by creating a new app and enabling hermes in that one and it worked, so I compared the build.gradle files of both and found out

               def hermesPath = "../../node_modules/hermes-engine/android/"; 

is used in if(enableHermes) instead "../../node_modules/hermesvm/android/" . Wondering why they didn't mention this in the getting started documents.

solved my issue! I had this problem when changed my project to monorepo.

iJimmyWei commented 3 years ago

Hermes renamed their binary from hermes to hermesc a while ago - https://github.com/facebook/react-native/commit/4305a291a9408ca65847994bbec42f1fbc97071d

You should make sure you change it accordingly too, like this:

project.ext.react = [
    ...
    hermesCommand: "../../node_modules/hermesvm/%OS-BIN%/hermesc", // notice the extra "C"
    ...
]
hanabalon commented 1 year ago

O.K. solved it by creating a new app and enabling hermes in that one and it worked, so I compared the build.gradle files of both and found out

               def hermesPath = "../../node_modules/hermes-engine/android/"; 

is used in if(enableHermes) instead "../../node_modules/hermesvm/android/" . Wondering why they didn't mention this in the getting started documents.

Thanks! this approach worked for me too, but replacing for:

    if (enableHermes) {
        //noinspection GradleDynamicVersion
        implementation("com.facebook.react:hermes-engine:+") { // From node_modules
            exclude group:'com.facebook.fbjni'
        }
    } else {
        implementation jscFlavor
    }
thanveershah commented 1 year ago

hermesCommand

Adding this gave me this version error

> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
   > The minCompileSdk (31) specified in a
     dependency's AAR metadata (META-INF/com/android/build/gradle/aar-metadata.properties)
     is greater than this module's compileSdkVersion (android-30).
     Dependency: androidx.appcompat:appcompat:1.4.1.
     AAR metadata file: C:\Users\user\.gradle\caches\transforms-3\0e660b8bafa777eda46724d78ef391ea\transformed\appcompat-1.4.1\META-INF\com\android\build\gradle\aar-metadata.properties.