Open marek-saji opened 1 month ago
I believe this is no longer an issue in the current version of Hermes.
The file in the error (API/hermes/inspector/chrome/tests/SerialExecutor.cpp
) no longer exists:
https://github.com/facebook/hermes/tree/main/API/hermes/inspector/chrome/tests
The current equivalent no longer uses std::runtime_error
:
https://github.com/facebook/hermes/blob/175d85f42a61b48d561aeab82243d4f58eeb1129/lib/Support/SerialExecutor.cpp#L21
@mattbfb You are right — thought I’m getting a (different) error on current main
:
FAILED: API/hermes/CMakeFiles/libhermes.dir/cdp/DomainState.cpp.o
/usr/bin/c++ -DHERMESVM_ALLOW_COMPRESSED_POINTERS -DHERMESVM_ALLOW_CONCURRENT_GC -DHERMESVM_ALLOW_CONTIGUOUS_HEAP -DHERMESVM_ALLOW_INLINE_ASM -DHERMESVM_GC_HADES -DHERMESVM_HEAP_SEGMENT_SIZE_KB=4096 -DHERMESVM_INDIRECT_THREADING -DHERMES_CHECK_NATIVE_STACK -DHERMES_ENABLE_DEBUGGER -DHERMES_ENABLE_UNICODE_REGEXP_PROPERTY_ESCAPES -DHERMES_MEMORY_INSTRUMENTATION -DHERMES_RELEASE_VERSION=\"0.12.0\" -DHERMES_SLOW_DEBUG -Dlibhermes_EXPORTS -I/home/saji/local/src/hermes/external -I/home/saji/local/src/hermes/external/flowparser/include -I/home/saji/local/src/hermes/include -I/home/saji/local/src/hermes/build/include -I/home/saji/local/src/hermes/external/llvh/include -I/home/saji/local/src/hermes/external/llvh/gen/include -I/home/saji/local/src/hermes/build/external/llvh/include -I/home/saji/local/src/hermes/API/hermes/.. -I/home/saji/local/src/hermes/API/hermes/../../public -I/home/saji/local/src/hermes/API/jsi -I/home/saji/local/src/hermes/API/jsi/jsi/.. -I/home/saji/local/src/hermes/public/hermes/Public/../.. -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -Wno-maybe-uninitialized -Wno-init-list-lifetime -Wno-redundant-move -Wno-deprecated-copy -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -ffp-contract=on -ffunction-sections -fdata-sections -fvisibility=hidden -g -std=c++17 -fPIC -MD -MT API/hermes/CMakeFiles/libhermes.dir/cdp/DomainState.cpp.o -MF API/hermes/CMakeFiles/libhermes.dir/cdp/DomainState.cpp.o.d -o API/hermes/CMakeFiles/libhermes.dir/cdp/DomainState.cpp.o -c /home/saji/local/src/hermes/API/hermes/cdp/DomainState.cpp
Bug Description
Hermes git revision: tried
main
(175d85f42),rn/0.75-stable
(1edbe36ce),rn/0.74-stable
(7bda0c267) React Native version: N/A OS: Linux Platform: x86_64Steps To Reproduce
Followed instructions from README: