dulinriley
commented
4 years ago I think the root cause is in facebook::jsi::valueFromDynamic:
case folly::dynamic::OBJECT: {
Object ret(runtime);
for (const auto& element : dyn.items()) {
Value value = valueFromDynamic(runtime, element.second);
if (element.first.isNumber() || element.first.isString()) {
ret.setProperty(runtime, element.first.asString().c_str(), value); // HERE
}
}
return std::move(ret);
}This code will call into setProperty with a const char *, which it assumes is ASCII.
What is most likely happening is that you have a non-ASCII character going over the bridge (MessageQueue).
@HeribertoAlves, if you are willing to make a small change to the C++ files and re-compile your app,
can you try changing the line I show in valueFromDynamic (in JSIDynamic.cpp) to be this instead?
ret.setProperty(runtime, PropNameID::forUtf8(runtime, element.first.asString()), value);If that fixes the issue, you or I can open up a PR for that fix to JSI.
HeribertoAlves
mtford90
I open this new issue as @dulinriley requested. It crash with the error below:
A/libc: /Users/willholen/intern/hermes/API/hermes/hermes.cpp:1378: auto facebook::hermes::HermesRuntimeImpl::createStringFromAscii(const char *, size_t)::(anonymous class)::operator()() const: assertion "static_cast(str[i]) < 128 && "non-ASCII character in string"" failed Fatal signal 6 (SIGABRT), code -6 in tid 22378 (mqt_js)
stack trace:
tgkill 0x0000007fb2680838 abort 0x0000007fb2632ed4 libc_fatal 0x0000007fb263aee0 _assert2 0x0000007fb2633624 facebook::hermes::HermesRuntimeImpl::createStringFromAscii(char const, unsigned long) 0x0000007f8e129914 void facebook::jsi::Object::setPropertyfacebook::jsi::Value&(facebook::jsi::Runtime&, char const, facebook::jsi::Value&&&) 0x0000007f9030b458 facebook::jsi::valueFromDynamic(facebook::jsi::Runtime&, folly::dynamic const&) 0x0000007f9030b198 facebook::jsi::valueFromDynamic(facebook::jsi::Runtime&, folly::dynamic const&) 0x0000007f9030b154 facebook::jsi::valueFromDynamic(facebook::jsi::Runtime&, folly::dynamic const&) 0x0000007f9030b154 facebook::jsi::valueFromDynamic(facebook::jsi::Runtime&, folly::dynamic const&) 0x0000007f9030b0cc facebook::react::JSIExecutor::invokeCallback(double, folly::dynamic const&) 0x0000007f902fe01c lldb_unnamed_symbol185$$libreactnativejni.so 0x0000007f90ba7dc4 _lldb_unnamedsymbol228$$libreactnativejni.so 0x0000007f90ba8de4 lldb_unnamed_symbol42$$libreactnativejni.so 0x0000007f90b6b8c0 facebook::jni::detail::MethodWrapper<void (facebook::react::JNativeRunnable::)(), &(facebook::react::JNativeRunnable::run()), facebook::react::JNativeRunnable, void>::dispatch(facebook::jni::alias_ref<facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::react::JNativeRunnable, facebook::react::Runnable>::JavaPart, facebook::react::Runnable, void>::_javaobject>) 0x0000007f90b5ac78 facebook::jni::detail::FunctionWrapper<void ()(facebook::jni::alias_ref<facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::react::JNativeRunnable, facebook::react::Runnable>::JavaPart, facebook::react::Runnable, void>::_javaobject>), &(facebook::jni::detail::MethodWrapper<void (facebook::react::JNativeRunnable::)(), &(facebook::react::JNativeRunnable::run()), facebook::react::JNativeRunnable, void>::dispatch(facebook::jni::alias_ref<facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::react::JNativeRunnable, facebook::react::Runnable>::JavaPart, facebook::react::Runnable, void>::_javaobject>)), facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::react::JNativeRunnable, facebook::react::Runnable>::JavaPart, facebook::react::Runnable, void>::_javaobject, void>::call(_JNIEnv, _jobject) 0x0000007f90b5abf4 art_quick_generic_jni_trampoline 0x0000007fae2bc504 0x00000000996d5bd8 art::ArtMethod::Invoke(art::Thread, unsigned int, unsigned int, art::JValue, char const) 0x0000007fade82da4 art::interpreter::ArtInterpreterToCompiledCodeBridge(art::Thread, art::ArtMethod, art::DexFile::CodeItem const, art::ShadowFrame, art::JValue) 0x0000007fae02d488 bool art::interpreter::DoCall<false, false>(art::ArtMethod, art::Thread, art::ShadowFrame&, art::Instruction const, unsigned short, art::JValue) 0x0000007fae027b50 bool art::interpreter::DoInvoke<(art::InvokeType)0, false, false>(art::Thread, art::ShadowFrame&, art::Instruction const, unsigned short, art::JValue) 0x0000007fae054a64 art::JValue art::interpreter::ExecuteSwitchImpl<false, false>(art::Thread, art::DexFile::CodeItem const, art::ShadowFrame&, art::JValue, bool) 0x0000007fae04c040 art::interpreter::Execute(art::Thread, art::DexFile::CodeItem const, art::ShadowFrame&, art::JValue, bool) 0x0000007fae008930 art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread, art::DexFile::CodeItem const, art::ShadowFrame, art::JValue) 0x0000007fae00efcc bool art::interpreter::DoCall<false, false>(art::ArtMethod, art::Thread, art::ShadowFrame&, art::Instruction const, unsigned short, art::JValue) 0x0000007fae027b30 bool art::interpreter::DoInvoke<(art::InvokeType)3, false, false>(art::Thread, art::ShadowFrame&, art::Instruction const, unsigned short, art::JValue) 0x0000007fae05280c art::JValue art::interpreter::ExecuteSwitchImpl<false, false>(art::Thread, art::DexFile::CodeItem const, art::ShadowFrame&, art::JValue, bool) 0x0000007fae04fbec art::interpreter::Execute(art::Thread, art::DexFile::CodeItem const, art::ShadowFrame&, art::JValue, bool) 0x0000007fae008930 artQuickToInterpreterBridge 0x0000007fae28e958 art_quick_to_interpreter_bridge 0x0000007fae2bc620 0x00000000996983e0