facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.12k stars 2.98k forks source link

get_html_translation_table() return value differs from PHP #1100

Closed Yermo closed 10 years ago

Yermo commented 10 years ago

HHVM get_html_translation_table() does not return the same values as Zend.

... <?php

$table = get_html_translation_table( HTML_ENTITIES, ENT_QUOTES );

print_r( $table ); ...

The current build of HHVM (as of today):

... commit 3322b171ab4f6d020ae2eb4920432e4324c3a982 Author: bsimmers bsimmers@fb.com Date: Fri Sep 27 10:21:36 2013 -0700

Kill fgets_socket_variation1.php with fire

It's flaky on contbuild

Reviewed By: @edwinsmith

Differential Revision: D987629

...

returns:

... Array ( [ ] => Π [¡] => Ρ [¢] => ¢ [£] => Σ [¤] => Τ [¥] => ⊥ [¦] => Φ [§] => Χ [¨] => Ψ [©] => Ω [ª] => ª [«] => « [¬] => € [­] => ­ [®] => ® [¯] => ¯ [°] => ° [±] => α [²] => β [³] => γ [´] => δ [µ] => ↵ [¶] => ζ [·] => η [¸] => θ [¹] => ι [º] => κ [»] => λ [¼] => μ [½] => ν [¾] => ξ [¿] => ο [À] => π [Á] => ρ [Â] => ς [Ã] => σ [Ä] => τ [Å] => ⋅ [Æ] => φ [Ç] => χ [È] => ψ [É] => ω [Ê] => ◊ [Ë] => Ë [Ì] => Ì [Í] => Í [Î] => Î [Ï] => Ï [Ð] => ⇐ [Ï] => Ï [Ð] => ⇐ [Ñ] => ⇑ [Ò] => ⇒ [Ó] => ⇓ [Ô] => ⇔ [Õ] => ⇕ [Ö] => ϖ [×] => × [Ø] => Ø [Ù] => Ù [Ú] => ⇚ [Û] => ⇛ [Ü] => ˜ [Ý] => ↝ [Þ] => Þ [ß] => ß [à] => à [á] => á [â] => â [ã] => ã [ä] => ä [å] => å [æ] => æ [ç] => ç [è] => è [é] => é [ê] => ê [ë] => ë [ì] => ì [í] => í [î] => î [ï] => ï [ð] => ð [ñ] => ñ [ò] => ò [ó] => ó [ô] => ô [õ] => õ [ö] => ö [÷] => ÷ [ø] => ø [ù] => ù [ú] => ú [û] => û [ü] => ü [ý] => ý [þ] => þ [ÿ] => ÿ [R] => Œ [S] => œ [R] => Œ [S] => œ [`] => ♠ [a] => ≡ [x] => Ÿ [<92>] => → [<91>] => ↑ [<93>] => ↓ [<94>] => ↔ [<95>] => ⊕ [<96>] => Ζ [<97>] => ⊗ [<98>] => Θ [<99>] => Ι [<9a>] => Κ [<9b>] => Λ [<9c>] => Μ [<9d>] => Ν [<9e>] => Ξ [<9f>] => Ο [^B] => ∂ [^C] => ∃ [ ] => ⌉ [^L] => ∌ [^M] => ϶ [^N] => ‎ [^O] => ∏ [^S] => ∓ [^T] => ∔ [^X] => ∘ [^Y] => ’ [^Z] => √ [^] => ℜ [^]] => ∝ [^^] => ∞ [ ] => ∠ [!] => ∡ ["] => " [&] => & [0] => ‰ [2] => ′ [3] => ″ [9] => ‹ [:] => › [>] => > [D] => ≄ [^Q] => ∑ [5] => ∵ [<90>] => ← [^@] => ∀ [^A] => ∁ [^@] => ∀ [^A] => ∁ [^D] => ∄ [^E] => ∅ [^G] => ∇ [^H] => ⌈ [ ] => ⌊ [^K] => ⌋ [^P] => ∐ [^R] => − [^V] => ∖ [^W] => ∗ [^_] => &ang90; [#] => ∣ [$] => ∤ [%] => ∥ ['] => ' [(] => ∨ [)] => ⟨ [*] => ⟩ [+] => ∫ [.] => ∮ [4] => ∴ [<] => < [=] => ∽ [@] => ≀ [A] => ≁ [C] => ≃ [E] => ≅ [G] => ≇ [H] => ≈ [I] => ≉ [J] => ≊ [L] => ≌ [M] => ≈ [N] => ≎ [O] => ≏ [d] => ≤ [e] => ♥ [f] => ♦ [g] => ≧ [h] => ≨ [i] => ≩ [j] => ≪ [k] => ≫ [l] => ≬ [n] => ≮ [o] => ≯ [p] => ⩽̸ [q] => ⩾̸ [p] => ⩽̸ [q] => ⩾̸ [r] => ≲ [s] => ≳ [v] => ≶ [w] => ≷ [z] => ≺ [{] => ≻ [|] => &cupre; [}] => &sscue; [~] => ≾ [^?] => ≿ [<80>] => ⊀ [<81>] => ⊁ [<82>] => ⊂ [<83>] => ⊃ [<84>] => ⊄ [<85>] => ⊅ [<86>] => ⊆ [<87>] => ⊇ [c] => ♣ ) ...

PHP as shipped with Ubuntu 12.04 LTS

PHP 5.3.10-1ubuntu3.7 with Suhosin-Patch (cli) (built: Jul 15 2013 18:05:44) Copyright (c) 1997-2012 The PHP Group Zend Engine v2.3.0, Copyright (c) 1998-2012 Zend Technologies

returns:

... Array ( [ ] =>   [¡] => ¡ [¢] => ¢ [£] => £ [¤] => ¤ [¥] => ¥ [¦] => ¦ [§] => § [¨] => ¨ [©] => © [ª] => ª [«] => « [¬] => ¬ [­] => ­ [®] => ® [¯] => ¯ [°] => ° [±] => ± [²] => ² [³] => ³ [´] => ´ [µ] => µ [¶] => ¶ [·] => · [¸] => ¸ [¹] => ¹ [º] => º [»] => » [¼] => ¼ [½] => ½ [¾] => ¾ [¿] => ¿ [À] => À [Á] => Á [Â] => Â [Ã] => Ã [Ä] => Ä [Å] => Å [Æ] => Æ [Ç] => Ç [È] => È [É] => É [Ê] => Ê [Ë] => Ë [Ì] => Ì [Í] => Í [Î] => Î [Ï] => Ï [Ð] => Ð [Ï] => Ï [Ð] => Ð [Ñ] => Ñ [Ò] => Ò [Ó] => Ó [Ô] => Ô [Õ] => Õ [Ö] => Ö [×] => × [Ø] => Ø [Ù] => Ù [Ú] => Ú [Û] => Û [Ü] => Ü [Ý] => Ý [Þ] => Þ [ß] => ß [à] => à [á] => á [â] => â [ã] => ã [ä] => ä [å] => å [æ] => æ [ç] => ç [è] => è [é] => é [ê] => ê [ë] => ë [ì] => ì [í] => í [î] => î [ï] => ï [ð] => ð [ñ] => ñ [ò] => ò [ó] => ó [ô] => ô [õ] => õ [ö] => ö [÷] => ÷ [ø] => ø [ù] => ù [ú] => ú [û] => û [ü] => ü [ý] => ý [þ] => þ [ÿ] => ÿ [&] => & ["] => " [&] => & ["] => " ['] => ' [<] => < [>] => > ) ...

scannell commented 10 years ago

Thanks for reporting this. It's not on our list of priorities at the moment but we'd welcome a PR.

ptarjan commented 10 years ago

Should be fixed by 1445bce38d24ab8b4c3a582d863fdfec25b49b4d and bcdfa958c349523e3d7339c333563b00a77e159b