facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.15k stars 2.99k forks source link

FastCGI socket owner, group and mode change support #4836

Open JoelMarcey opened 9 years ago

JoelMarcey commented 9 years ago

There was a pull request for this that never landed due to inactivity, but could be used as a starting point.

https://reviews.facebook.net/D30039

ghost commented 9 years ago

@JoelMarcey : is it possible you can add support for setting ACLs on it like php-fpm does? That would make it quite a bit easier for me to make official fedora packages for hhvm for both apache and nginx users.

the-infinity commented 9 years ago

Could this patch be added some day? Because it's quite difficult to use hhvm in enviroments with different users for http and php at the moment.

ghost commented 9 years ago

that patch as is , does not work. I tried it myself. HHVM drops root permissions too early for the socket ownership to be changed. The original author needs to come back and fix that.

knofte commented 9 years ago

Or someone else just take over, redo from new branch.