search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.16k stars 2.99k forks source link

[IGNORE] extract() in closure causes segfault #6460

Closed Daniel15 closed 8 years ago

Daniel15 commented 8 years ago

After upgrading from 3.9.1 to 3.10.1 via Debian package (on Debian Testing), I'm encountering a segfault on the first request immediately after starting HHVM:

Core dumped: Segmentation fault
Stack trace in /tmp/stacktrace.8693.log

Contents of /tmp/stacktrace.8693.log:

PHP Stacktrace:

#0  extract(Array, 256) called at [/var/www/atarcalc/live/fuel/core/classes/view.php:230]
#1  Closure$Fuel\Core\View::process_file(/var/www/atarcalc/live/fuel/app/views/includes/react.php, Array) called at [/var/www/atarcalc/live/fuel/core/classes/view.php:252]
#2  Fuel\Core\View->process_file() called at [/var/www/atarcalc/live/fuel/core/classes/view.php:589]
#3  Fuel\Core\View->render() called at [/var/www/atarcalc/live/fuel/core/classes/view.php:205]
#4  Fuel\Core\View->__toString() called at [/var/www/atarcalc/live/fuel/app/views/mobile/template.php:54]
#5  include(/var/www/atarcalc/live/fuel/app/views/mobile/template.php) called at [/var/www/atarcalc/live/fuel/core/classes/view.php:238]
#6  Closure$Fuel\Core\View::process_file(/var/www/atarcalc/live/fuel/app/views/mobile/template.php, Array) called at [/var/www/atarcalc/live/fuel/core/classes/view.php:252]
#7  Fuel\Core\View->process_file() called at [/var/www/atarcalc/live/fuel/core/classes/view.php:589]
#8  Fuel\Core\View->render() called at [/var/www/atarcalc/live/fuel/core/classes/view.php:205]
#9  Fuel\Core\View->__toString() called at [/var/www/atarcalc/live/fuel/core/classes/response.php:362]
#10 Fuel\Core\Response->__toString() called at [/var/www/atarcalc/live/public/index.php:109]

That file is core/classes/view.php from FuelPHP 1.7

Daniel15 commented 8 years ago

I upgraded to the nightly (2015.10.31~jessie) and that seems to be working fine, although I'm not really comfortable using a nightly release on a production server :)

Scratch that, I started encountering segfaults again after restarting the server :cry:

Confirmed that downgrading to 3.9.1 seems to have resolved it for now.

Edit: maybe not, I just saw it on 3.9.1. It seems to happen rarely on 3.9.1, but it does happen there too. I'll try to get a minimal repro soon.

Daniel15 commented 8 years ago

Got a standalone repro, I'll open a separate issue to avoid excess noise on this one.