XHP Issues with SVG on 3.23.1

[justinwray]

HHVM Version: 3.23.1

When returning XHP of an SVG tag a fatal error is thrown:

Fatal error: static analysis error: supposedly unreachable code was reached in /var/www/example/example.php on line 22

Example Code:

  public async function example(): Awaitable<:xhp> {
    return
      <svg
        id="example-map"
        xmlns="http://www.w3.org/2000/svg"
        amcharts="http://amcharts.com/ammap"
        xlink="http://www.w3.org/1999/xlink"
        viewBox="0 0 1008 651"
        preserveAspectRatio="xMidYMid meet">
        <defs>
          <amcharts:ammap
            projection="mercator"
            leftLongitude="-169.6"
            topLatitude="83.68"
            rightLongitude="190.25"
            bottomLatitude="-55.55">
          </amcharts:ammap>
        </defs>
        <g class="view-controller">
          <g class="country-hover"></g>
        </g>
      </svg>;

Expected Result: Return XHP of SVG

Actual Result: Fatal Unreachable Error.

[justinwray]

Tagging: @fredemmott @stevcoll @gsingh93

[fredemmott]

Are you using repo authoritative mode? Did this work on past releases?

[stevcoll]

@fredemmott No this was tested with repo authoritative mode off. This code worked fine on all previous releases. We are currently running it on HHVM 3.21 with no errors.

[fredemmott]

Huh. That error looks like it's only generated by hhbbc, which isn't supposed to be executed unless you're in repo-auth-mode

[lexidor]

I am going over old issues on this repository, to see which ones apply to the current versions of hhvm.

I reran your repro. I declared the xhp classes for the elements. The code worked fine in both repo auth and live mode. Xhp has undergone some major changes since this issue was created, so the underlying issue may have moved.