search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Use `*` instead of `\+` in update-first-party.sh #9143

Closed Atry closed 2 years ago

Atry commented 2 years ago

This PR uses * instead of \+ in update-first-party.sh because the BSD sed from macOS does not support \+, which is not POSIX standard.

Test Plan:

9144 is created by the updated version of this script from macOS, which was able to update the hash with *, but not with \+.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.