search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Move fb-mysql to a submodule #9150

Closed Atry closed 2 years ago

Atry commented 2 years ago

As @fredemmott suggested in https://github.com/facebook/hhvm/issues/9106#issuecomment-1171766088, we can add ShipIt mappings to improve atomicity for first-party dependencies.

This diff is the first step to stop downloading dependencies from tarballs. It temporarily uses git submodule and I will create another diff to remove the git submodule and create ShipIt mappings.

Test Plan:

Sandcastle jobs and GitHub Actions should pass

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D38726133

facebook-github-bot commented 2 years ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D38726133

facebook-github-bot commented 2 years ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D38726133

facebook-github-bot commented 2 years ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Atry commented 2 years ago

This PR is replaced by 3e69567d27f215158afc4e5d219dc32021c10201